Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of [NSObject valueForKeyPath:] #904

Closed
rupertdaniel opened this issue Aug 23, 2016 · 1 comment
Closed

Improve performance of [NSObject valueForKeyPath:] #904

rupertdaniel opened this issue Aug 23, 2016 · 1 comment
Assignees
@DHowett-MSFT
Labels
Area-Foundation Bug
Milestone
1609

Comments

@rupertdaniel
Copy link

When using [NSObject valueForKeyPath:] there seems to be a heavy performance impact. This is very noticeable for example when using an NSSortDescriptor to sort a large array.

When profiling the app it seems a lot of time in [NSObject valueForKeyPath:] is spent processing the actual NSString of the key path.

Attached is a screen grab of the relevant profile section.

screenshot 2016-08-23 13 02 02
@rajsesh rajsesh added this to the 1609 milestone Aug 23, 2016
DHowett-MSFT pushed a commit to DHowett-MSFT/WinObjC that referenced this issue Sep 13, 2016
@DHowett
Improve the performance of _NSKVCSplitKeypath by using CF functions.
d9849bf 
References microsoft#904.
DHowett-MSFT pushed a commit to DHowett-MSFT/WinObjC that referenced this issue Sep 13, 2016
@DHowett
Do not create NSInvocations for quickget on nil values. Ref microsoft…
e732651 
…#904.
@DHowett-MSFT DHowett-MSFT mentioned this issue Sep 13, 2016
Merged
DHowett-MSFT pushed a commit that referenced this issue Sep 20, 2016
@DHowett
Improve the performance of -[NSObject valueForKeyPath:]. (#1005)
2b8e783 
* Improve the performance of _NSKVCSplitKeypath by using CF functions.
* Do not create NSInvocations for quick get on nil values.

References #904.
@DHowett-MSFT
Copy link

This is fixed as of the merge of #1005.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-Foundation Bug
Projects
None yet
Milestone
1609
Development

No branches or pull requests
4 participants
@rupertdaniel @ashvarma @DHowett-MSFT @rajsesh