Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a CoreData xcdatamodel parser. #610

Merged
merged 5 commits into from
Jul 23, 2016

Conversation

DHowett-MSFT
Copy link

@DHowett-MSFT DHowett-MSFT commented Jul 5, 2016

The intent of this pull request is to implement the basic functionality required by NSManagedObjectModel.
In lieu of precompiling the model into a binary format, CoreData will thaw it from XML at runtime.

Quick Notes

  • Based on CoreFoundation's SAX XML parser.
  • Supports most basic entity configuration, attributes, relationships, inversion.
  • Makes a best-effort attempt to create constraints for max/min values on attributes.
  • does not support fetch requests or multiple configurations.

@property (readonly, copy) NSDictionary* fetchRequestTemplatesByName STUB_PROPERTY;
- (NSFetchRequest*)fetchRequestTemplateForName:(NSString*)name STUB_METHOD;
- (NSFetchRequest*)fetchRequestTemplateForName:(NSString*)name STUB_PROPERTY;
Copy link
Author

@DHowett-MSFT DHowett-MSFT Jul 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this should not have changed from STUB_METHOD. #Pending

@rajsesh
Copy link
Contributor

rajsesh commented Jul 8, 2016

:shipit:

@DHowett-MSFT
Copy link
Author

I added an in-depth single entity two-property test; one attribute and one relationship. It doesn't get into any attribute constraints, but it does make sure that a lot of the basic parseable keys are intact.

</ProjectReference>
<ProjectReference Include="..\..\Starboard\dll\Starboard.vcxproj">
<Project>{0AC27ECF-E2AB-420B-9359-4843FFF4CBFA}</Project>
</ProjectReference>
Copy link
Member

@bbowman bbowman Jul 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this if its using sdk-build.props. #Pending

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.


In reply to: 70720366 [](ancestors = 70720366)

@DHowett-MSFT DHowett-MSFT force-pushed the 201606-coredata-parser branch from f64194c to f72642c Compare July 19, 2016 18:53
@jofre-ms
Copy link
Contributor

:shipit:

@DHowett-MSFT
Copy link
Author

In CI build.

@DHowett-MSFT DHowett-MSFT merged commit f84d718 into microsoft:develop Jul 23, 2016
@DHowett-MSFT DHowett-MSFT deleted the 201606-coredata-parser branch July 23, 2016 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants