-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to newer ICU binaries (5.7) #668
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,7 +125,7 @@ | |
<GenerateWindowsMetadata>false</GenerateWindowsMetadata> | ||
<ModuleDefinitionFile>CoreFoundation.def</ModuleDefinitionFile> | ||
<GenerateDebugInformation>true</GenerateDebugInformation> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;icudata.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
<AdditionalLibraryDirectories>$(StarboardBasePath)\Frameworks\limbo;$(AdditionalLibraryDirectories)</AdditionalLibraryDirectories> | ||
<TreatLinkerWarningAsErrors>false</TreatLinkerWarningAsErrors> | ||
</Link> | ||
|
@@ -152,7 +152,7 @@ | |
<IgnoreAllDefaultLibraries>false</IgnoreAllDefaultLibraries> | ||
<GenerateWindowsMetadata>false</GenerateWindowsMetadata> | ||
<ModuleDefinitionFile>CoreFoundation.def</ModuleDefinitionFile> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;icudata.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
hooray!! Any numbers on the reduced dll size? #Resolved There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Net increase in size, probably because more complete data set now? In reply to: 71421348 [](ancestors = 71421348,71421042,71389811) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I think that'd be the case. Also reminder to everyone that eventually we'll consume this directly from windows, meaning we'll no longer take the hit. In reply to: 71459710 [](ancestors = 71459710,71421348,71421042,71389811) |
||
<AdditionalLibraryDirectories>$(StarboardBasePath)\Frameworks\limbo;$(AdditionalLibraryDirectories)</AdditionalLibraryDirectories> | ||
<TreatLinkerWarningAsErrors>false</TreatLinkerWarningAsErrors> | ||
</Link> | ||
|
@@ -181,7 +181,7 @@ | |
<GenerateWindowsMetadata>false</GenerateWindowsMetadata> | ||
<ModuleDefinitionFile>CoreFoundation.def</ModuleDefinitionFile> | ||
<GenerateDebugInformation>true</GenerateDebugInformation> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;icudata_arm.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
<AdditionalLibraryDirectories>$(StarboardBasePath)\Frameworks\limbo;$(AdditionalLibraryDirectories)</AdditionalLibraryDirectories> | ||
<TreatLinkerWarningAsErrors>false</TreatLinkerWarningAsErrors> | ||
</Link> | ||
|
@@ -208,7 +208,7 @@ | |
<IgnoreAllDefaultLibraries>false</IgnoreAllDefaultLibraries> | ||
<GenerateWindowsMetadata>false</GenerateWindowsMetadata> | ||
<ModuleDefinitionFile>CoreFoundation.def</ModuleDefinitionFile> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;icudata_arm.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
<AdditionalDependencies>mincore.lib;libxml2.lib;icudt.lib;icuin.lib;icuuc.lib;libdispatch.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
<AdditionalLibraryDirectories>$(StarboardBasePath)\Frameworks\limbo;$(AdditionalLibraryDirectories)</AdditionalLibraryDirectories> | ||
<TreatLinkerWarningAsErrors>false</TreatLinkerWarningAsErrors> | ||
</Link> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static cast? // WINOBJC comment? #Pending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not static cast, this is a C file and upstreamable.
In reply to: 71390074 [](ancestors = 71390074)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// WINOBJC: WinObjC seems to have stricter type-checking than the reference platform,
// so an explicit cast is required here
In reply to: 71390930 [](ancestors = 71390930,71390074)