Skip to content

Commit

Permalink
Update VSIX to work with Dev17 (#936)
Browse files Browse the repository at this point in the history
This change updates the VSIX to target the next version of VS. Fortunately, this VSIX contains only templates and no code, so it can target both Dev16 and Dev17 fairly easily.
  • Loading branch information
DefaultRyan committed Jul 14, 2021
1 parent 0be5366 commit 6fac824
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 10 deletions.
2 changes: 1 addition & 1 deletion dev/VSIX/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
https://pkgs.dev.azure.com/microsoft/ProjectReunion/_packaging/Project.Reunion.nuget.internal/nuget/v3/index.json
</RestoreSources>
<CppWinRTVersion Condition="'$(CppWinRTVersion)' == ''">2.0.210211.2</CppWinRTVersion>
<ReunionVersion Condition="'$(ReunionVersion)' == ''">0.5.0-prerelease.20210304.5.ci</ReunionVersion>
<ReunionVersion Condition="'$(ReunionVersion)' == ''">0.5.7</ReunionVersion>
</PropertyGroup>

<PropertyGroup>
Expand Down
6 changes: 3 additions & 3 deletions dev/VSIX/Extension/ProjectReunion.Extension.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@
<Reference Include="System" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="16.0.206" ExcludeAssets="runtime">
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.0.0-previews-1-31325-273" ExcludeAssets="runtime">
<IncludeAssets>compile; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="16.8.1017">
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.0.1600">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down Expand Up @@ -284,7 +284,7 @@
Condition="'$(EnableExperimentalVSIXFeatures)'=='true'"
XmlInputPath="$(VsixManifestSource)"
Query="/ns:PackageManifest/ns:Metadata/ns:Identity/@Id"
Value="$(_OriginalVsixId).Preview"
Value="$(_OriginalVsixId).Preview"
Namespaces="&lt;Namespace Prefix='ns' Uri='http://schemas.microsoft.com/developer/vsx-schema/2011' /&gt;" />
<XmlPoke
Condition="'$(EnableExperimentalVSIXFeatures)'=='true'"
Expand Down
27 changes: 21 additions & 6 deletions dev/VSIX/Extension/source.extension.vsixmanifest
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,32 @@
<Preview>false</Preview>
</Metadata>
<Installation AllUsers="true">
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[16.9, 17.0)" />
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[16.9, 17.0)" />
<InstallationTarget Id="Microsoft.VisualStudio.Enterprise" Version="[16.9, 17.0)" />
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[16.9, 17.0)">
<ProductArchitecture>x86</ProductArchitecture>
</InstallationTarget>
<InstallationTarget Id="Microsoft.VisualStudio.Community" Version="[17.0, 18.0)">
<ProductArchitecture>amd64</ProductArchitecture>
</InstallationTarget>
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[16.9, 17.0)">
<ProductArchitecture>x86</ProductArchitecture>
</InstallationTarget>
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[17.0, 18.0)">
<ProductArchitecture>amd64</ProductArchitecture>
</InstallationTarget>
<InstallationTarget Id="Microsoft.VisualStudio.Enterprise" Version="[16.9, 17.0)">
<ProductArchitecture>x86</ProductArchitecture>
</InstallationTarget>
<InstallationTarget Id="Microsoft.VisualStudio.Enterprise" Version="[17.0, 18.0)">
<ProductArchitecture>amd64</ProductArchitecture>
</InstallationTarget>
</Installation>
<Dependencies>
<Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="[4.5,)" />
</Dependencies>
<Prerequisites>
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[16.0,17.0)" DisplayName="Visual Studio core editor" />
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.Support" Version="[16.2.29003.222,17.0)" DisplayName="Universal Windows Platform tools" />
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.VC" Version="[16.0,17.0)" DisplayName="C++ (v142) Universal Windows Platform tools" />
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[16.0,18.0)" DisplayName="Visual Studio core editor" />
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.Support" Version="[16.2.29003.222,18.0)" DisplayName="Universal Windows Platform tools" />
<Prerequisite Id="Microsoft.VisualStudio.ComponentGroup.UWP.VC" Version="[16.0,18.0)" DisplayName="C++ (v142) Universal Windows Platform tools" />
</Prerequisites>
<Reference Id="NuPackToolsVsix.Microsoft.67e54e40-0ae3-42c5-a949-fddf5739e7a5" MinVersion="1.7.30402.9028">
<Name>NuGet Package Manager</Name>
Expand Down

0 comments on commit 6fac824

Please sign in to comment.