User/purifoypaul/rs5 packaged com activation #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pmpurifoy
commented
Jan 30, 2022
pmpurifoy
commented
- Plumb packaged com clsid to LRP for CoCreateInstance
- Fix CreateChannelRequest to work with new UDK fixes
- Added logic to parse the correct IBackgroundTaskInstance in packaged/unpackaged scenarios
pmpurifoy
requested review from
sharath2727,
danielayala94,
loneursid,
hulumane and
David-Quero
ghost
added
the
|
This PR needs to be rebased but I wanted to post a current functioning version of RS5 for packaged. Affected files are
|
jonwis
approved these changes
Jan 31, 2022
dev/PushNotifications/PushNotificationsLongRunningTask/NotificationListener.cpp
Outdated
Show resolved
Hide resolved
loneursid
added
the
area-Notifications
pmpurifoy
changed the base branch from
WNP_ToastNotifications_L2
to
user/purifoypaul/RS5Fixes
pmpurifoy
commented
Jan 31, 2022
pmpurifoy
added a commit
that referenced
this pull request
Feb 2, 2022
* Initial Commit * Working packaged background RS5 * Remove IRawSerializer * Update NotificationListener.cpp
pmpurifoy
added a commit
that referenced
this pull request
Feb 14, 2022
* Wnp toast notifications (#1981) * Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Forward integrate main into WNP_ToastNotifications (#1970) * Added header so MddBootstrapAutoInitializer.cpp compiles regardless of precompiled headers (#1947) * Update dependencies from https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionInternal build Maestro-UpdateEngCommon_2201.10001 (#1962) Microsoft.WinAppSDK.EngCommon From Version 1.0.0-20211213.0-CI -> To Version 1.0.0-20220110.0-CI Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Run the Foundation test suite from the Internal Integraiton tests (#1963) Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Revert "Forward integrate main into WNP_ToastNotifications (#1970)" This reverts commit a981a1e. Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * User/erlangl/purifoypaul/arm64 build fix (#1983) * Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Forward integrate main into WNP_ToastNotifications (#1970) * Added header so MddBootstrapAutoInitializer.cpp compiles regardless of precompiled headers (#1947) * Update dependencies from https://dev.azure.com/microsoft/ProjectReunion/_git/ProjectReunionInternal build Maestro-UpdateEngCommon_2201.10001 (#1962) Microsoft.WinAppSDK.EngCommon From Version 1.0.0-20211213.0-CI -> To Version 1.0.0-20220110.0-CI Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Run the Foundation test suite from the Internal Integraiton tests (#1963) Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Fixing build files for ToastNotificationTestApp/ToastNotificationTests * File was renamed to main Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Add ToastNotificationManger::Setting API (#1984) * Add ToastNotificationManger::Setting API * Addressing nits * Update ToastNotificationManager.cpp * Add Foreground/Background handlers for ToastActivation (#1973) * Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Copy branch based on WNP_ToastNotifications * Address nit * Addressing nits * Address nits * Change name from ToastActivation->AppNotification * Change more constants * Reuse deserialize function Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> * Implemented ToastNotification + unit tests (#1996) Implemented ToastNotification + unit tests * Add ToastRegistration functions to PushNotificationsLongRunningTask (#1976) * Adding temp idl for base branch * Create .cpp/.h files for handling toastnotifications * Introduce ToastNotification Registration APIs (#1875) * Introduce ToastRegistration APIs and associated taef tests * Address comments * Address minor comments * Add support for Release x64 for ToastNotificationTestApp * Addressing nits * Add GetActivatorGuid function * Last nits * Update error messages Co-authored-by: Paul Purifoy <purifoypaul@microsoft.com> * Rebase to WPN_ToastNotifications * Update externs.h * Rename toastGuid->appId * Addressing nits * Add sink check to AddToastRegistrationMapping * Adding lock to HasSinkForAppId * Change lock to shared lock * Add unit tests, rename appId->toastAppId * Add BuildAppIdentifier * Remove HasSinkForAppId * Move toastStorage to ToastNotificationManager * Address nits * Update platform.cpp * Adding packaged apps treated as unpackaged scenario * Flip the bool * Update platform.cpp * Fix remaining nits * last nits Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> * First iteration of ToastNotificationDemoApp * Current iteration * Adding DelayLoad Bootstrap.dll to make app hybrid * Update PushNotificationManager.cpp * User/purifoypaul/rs5 packaged com activation (#2044) * Initial Commit * Working packaged background RS5 * Remove IRawSerializer * Update NotificationListener.cpp * Update PushActivationInfo * Currently working on nits * Addressing comments * Cleaning up PushNotificationChannel.cpp + nits * Issues with PushRawNotification * Update PushNotificationManager.cpp * Fixing some nits * Move CoCreate packaged apps to helpers * Remove background activation when args is handled * Update main.cpp * Remove legacyImplementation from telemetry * Add Default to TestApp * Update main.cpp * Update main.cpp Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: reunion-maestro[bot] <81196566+reunion-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Daniel Ayala <14967941+danielayala94@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.