Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of AppLifecycle and ActivationRegistrationManager APIs. #268

Merged
merged 17 commits into from
Oct 31, 2020

Conversation

aeloros
Copy link
Contributor

@aeloros aeloros commented Oct 30, 2020

Implement the first set of functionality for the AppLifecycle and ActivationRegistrationManager objects.
Support in this change is scoped to implementation of the LaunchActivatedEventArgs and ProtocolActivatedEventArgs scenarios for unpackaged Win32.
Sample APIs were removed from the tree.

Testing was done by adding basic launch tests, and testing protocol scenarios with a basic sample app. A later PR will contain protocol tests, and a move to the new test framework.

@aeloros aeloros self-assigned this Oct 30, 2020
@ghost ghost added the needs-triage label Oct 30, 2020
@aeloros aeloros requested review from jonwis and EHO-makai October 30, 2020 22:22
@aeloros aeloros linked an issue Oct 30, 2020 that may be closed by this pull request
dev/AppLifecycle/ActivatedEventArgsBase.h Outdated Show resolved Hide resolved
test/CppTest_UWP/pch.h Show resolved Hide resolved
dev/AppLifecycle/ProtocolActivatedEventArgs.h Show resolved Hide resolved
dev/AppLifecycle/AppLifecycle.h Outdated Show resolved Hide resolved
dev/AppLifecycle/AppLifecycle.cpp Show resolved Hide resolved
test/AppLifecycle/ApiTests.cpp Show resolved Hide resolved
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

namespace Microsoft.ProjectReunion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwis , I was imagining that we would not have anything in "Microsoft.ProjectReuion" namespace. Is this OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it is, but we should probably move this to Ms.AppModel.Something eventually

Copy link
Contributor

@EHO-makai EHO-makai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be additional changes for the file activation at which time we may change the namespace,

@jevansaks
Copy link
Member

@aeloros please change the title of this PR to have a human-readable one-line-description of this PR (Use the "Edit" button on the top right of the PR page)

@aeloros aeloros merged commit b3951a4 into main Oct 31, 2020
@aeloros aeloros deleted the user/aeloros/get_args branch October 31, 2020 03:51
@aeloros aeloros changed the title User/aeloros/get args Initial implementation of AppLifecycle and ActivationRegistrationManager APIs. Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Lifecycle
5 participants