-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSIX Dynamic Dependencies #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be committing pfx files. We should be able to use a signing task in the pipeline, where it can get the cert for signing. See build/MSTest.pfx
This is a test cert for inner loop testing. Tests need to make signed MSIXes for some tests e.g. test\DynamicDependency\data\DynamicDependency.DataStore.Msix\Makefile.mak Inner-loop development does not (cannot) require passing through pipeline tasks. Last thing anyone wants is F5 to build one project, then tap the build pipeline to sign a package so it can resume compiling and running test code |
I'm fine with this, but expect the code scanners to autoflag a private cert being checked in. You'll need to make those happy when this is flagged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got down to the tests, will review those in another pass.
Thanks for the heads up. I don't know what "make those happy" entails but I'll sure I'll learn :P The MSTest.cer+pfx are actually from some other PR or advice of @EHO-makai (?) when the old one expired last month. @EHO-makai @mikenelte were those updated in main or is the expired MSTest cert still present? If main was updated I can drop these out of my PR |
…or man's windbg !token + !peb).
… -CheckAll). Improve DevCheck help. Add 'Setup TAEF Service' to build pipeline
…atch the recent change to DevCheck's parameter syntax
… as a built-in Administrator account (Elevated and not a split token) which prevents TAEF RunAs:RestrictedUser from working. Given the CI/Pipeline running as a built-in Administrator account TAEF provides no way for us to work around it thus all AppLifecycleTests are Failed or Blocked (despite passing when run locally), and DynamicDependencies doesn't support Elevation so we can have passing tests that don't verify the actual primary target environment (DynDep, MediumIL) or failing tests that block all checkins. This problem will be solved when test execution (the whole pipeline?) is moved to Helix. When that happens we can reenable these tests.
…neration for inner-loop development needing signed MSIX. NOTE: This will be updated in a future PR to pull MSTest.pfx from the Azure Key Vault.
…Check.cmd is updated to pull MSTest.pfx from the Azure Key Vault
6c6c6ee
to
9a9b3d7
Compare
…it's needed to build some of the tests). Removed a debugging statement from DevCheck.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to put back my the Packaged Win32 tests, as they will be enabled very soon after your changes.
<FunctionLevelLinking>true</FunctionLevelLinking> | ||
<RemoveUnreferencedCodeData>false</RemoveUnreferencedCodeData> | ||
<OmitDefaultLibName>true</OmitDefaultLibName> | ||
<BufferSecurityCheck>false</BufferSecurityCheck> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you've explicitly disabled BufferSercurityCheck (aka /GS https://docs.microsoft.com/en-us/cpp/build/reference/gs-buffer-security-check?view=msvc-160)?
I'm running BinSkim on our binaries, and this is getting flagged.
It lives! MSIX Dynamic Dependencies implemented and tested
See Issue #89 MSIX Dynamic Dependencies - allow any process to use MSIX Framework packages
and specs/dynamicdependencies/DynamicDependencies.md
This includes...