Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for Cannot install version 1.3: DDLM package not found #4890

Merged
merged 1 commit into from
Nov 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion installer/dev/install.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,8 @@ namespace WindowsAppRuntimeInstaller
{
if (isPackageInstalledAndIsPackageStatusOK)
{
// If currently installed Package (either same or higher version than the version from the installer) is in good state, do nothing and return.
// If currently installed Package (either same or higher version than the version from the installer) is in good state, clear the package higher version and return.
installActivityContext.SetExistingPackageIfHigherVersion(L"");
return;
}
}
Expand Down Expand Up @@ -353,6 +354,9 @@ namespace WindowsAppRuntimeInstaller

// Re-register higher version of the package that is already installed.
hrDeploymentResult = RegisterPackage(installActivityContext, installActivityContext.GetExistingPackageIfHigherVersion().c_str(), forceDeployment);

// Clear the package higher version after it has been re-registered
installActivityContext.SetExistingPackageIfHigherVersion(L"");
}
else
{
Expand Down
Loading