Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CameraCaptureUI Spec Doc #4895

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Updating CameraCaptureUI Spec Doc #4895

merged 3 commits into from
Nov 19, 2024

Conversation

Saharsh979
Copy link
Contributor

This PR includes the following changes:

  1. The change updates the CameraCaptureUI specifications doc to include important notes on usage for PhotoSettings and VideoSettings.
  2. Added the CameraCaptureUIContract in the WinRT contracts as well.
  3. A small update by removing the marshalling=none and threading=STA attributes. These settings were relevant to the UWP version of CameraCapture, but they are no longer applicable in the context of WinAppSDK.

@Saharsh979
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Saharsh979
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Saharsh979 Saharsh979 merged commit 61c8a40 into main Nov 19, 2024
2 checks passed
@Saharsh979 Saharsh979 deleted the user/sahjaiswal/cameracapture-spec-update branch November 19, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hemantxk Hemantxk Hemantxk approved these changes

@godlytalias godlytalias godlytalias approved these changes

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saharsh979 @godlytalias @Hemantxk