Local Badge Notification code changes #4926
Merged
+915
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatwikKrSharma
requested review from
satkh,
JesseCol,
jonwis,
vivekkhare31,
Saharsh979,
akanpatel2206,
codendone and
Hemantxk
satkh
reviewed
Nov 29, 2024
|
i think if we are bringing in the hierarchy of base notification -> badge notification |
satkh
reviewed
Nov 29, 2024
satkh
reviewed
Nov 29, 2024
satkh
reviewed
Nov 29, 2024
satkh
reviewed
Nov 29, 2024
dev/Notifications/BadgeNotifications/BadgeNotificationManager.cpp
Outdated
Show resolved
Hide resolved
satkh
reviewed
Nov 29, 2024
satkh
reviewed
Nov 29, 2024
satkh
reviewed
Nov 29, 2024
dev/Notifications/BadgeNotifications/BadgeNotificationManager.cpp
Outdated
Show resolved
Hide resolved
satkh
reviewed
Nov 29, 2024
dev/Notifications/BadgeNotifications/BadgeNotificationManager.cpp
Outdated
Show resolved
Hide resolved
satkh
reviewed
Nov 29, 2024
satkh
reviewed
Nov 29, 2024
satkh
reviewed
Nov 29, 2024
jonwis
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Looking good. I think you can remove the BadgeNotification & BaseNotification types, though? If you need to update NotificationProperties to take a struct of parameters, or have a new ctor that knows "I'm being constructed with all defaults from the set badge notification path" then that's fine.
dev/Notifications/BaseNotifications/BaseNotificationManager.cpp
Outdated
Show resolved
Hide resolved
dev/Notifications/BadgeNotifications/BadgeNotificationManager.cpp
Outdated
Show resolved
Hide resolved
dev/Notifications/BadgeNotifications/BadgeNotificationManager.cpp
Outdated
Show resolved
Hide resolved
SatwikKrSharma
force-pushed
the
user/satwiksharma/badgeNotificationCodeChangesFinal
branch
from
dc52aef to
ba39226
Compare
jonwis
approved these changes
Dec 9, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SatwikKrSharma
deleted the
user/satwiksharma/badgeNotificationCodeChangesFinal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #138
API Spec - https://github.com/microsoft/WindowsAppSDK/pull/4823/files#diff-17dae42945b77909c6b45f1e7635b67969b8656882ccca5d20c56fd9ab653d6a
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.