Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows App SDK Installer] Functional Test Fixes #4947

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

ssparach
Copy link
Contributor

@ssparach ssparach commented Dec 9, 2024

This PR fixes the following issues for the Windows App SDK Installer functional tests:

  • The test expects the installer to be copied to a different directory instead of where the test module is located.
  • The tests do not construct the installer path correctly
    Error: Verify:IsTrue(std::filesystem::exists(GetInstallerPath())) [File: \installer\test\InstallerFunctionalTests\FunctionalTests.cpp, Function: WindowsAppRunTimeInstallerTests::FunctionalTests::ClassInit, Line 32]
    Error: TAEF: Setup fixture ‘WindowsAppRunTimeInstallerTests::FunctionalTests::ClassInit’ for the scope ‘WindowsAppRunTimeInstallerTests::FunctionalTests’ failed.
  • The installer does not return the expected exit code when run with the argument --help.
    Error: Verify: AreEqual(S_OK, result) - Values (0, -2147024895), \installer\test\InstallerFunctionalTests\FunctionalTests.cpp, Function: WindowsAppRuntimeInstallerTests::FunctionalTests::VerifyArgsHelp, Line: 68

The changes were confirmed by executing the functional tests and verifying that they all passed successfully.


A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@ssparach
Copy link
Contributor Author

ssparach commented Dec 9, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ssparach ssparach requested a review from Scottj1s December 9, 2024 23:48
@ssparach
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ssparach ssparach merged commit 0cc28b7 into main Dec 10, 2024
26 checks passed
@ssparach ssparach deleted the user/ssparach/runInstallerTests branch December 10, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants