Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove terminal velocity feature tag from OAuth2Manager APIs, enabling for stable release #5072

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

akanpatel2206
Copy link
Contributor

This PR removes the TerminalVelocity mechanism from the OAuth2Manager API, which was previously used to control its visibility across different release channels (Preview, Stable, Experimental). As the feature is now moving towards broader availability (Preview Release) and no longer needs the experimental feature flagging, we are removing the TerminalVelocity-related checks.

The API has gone through spec-review: #4772

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

@akanpatel2206
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@Hemantxk Hemantxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is step in pipeline which generate terminvelocity header file from xml in WindowsAppSDK-SetupBuildEnvironment-Steps.yml. What's the plan to remove that?

@microsoft microsoft deleted a comment from akanpatel Jan 27, 2025
@akanpatel2206
Copy link
Contributor Author

There is step in pipeline which generate terminvelocity header file from xml in WindowsAppSDK-SetupBuildEnvironment-Steps.yml. What's the plan to remove that?

We will remove .h, .xml and pipeline entry post stable release.

@Saharsh979
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akanpatel2206 akanpatel2206 enabled auto-merge (squash) January 27, 2025 12:05
@akanpatel2206 akanpatel2206 merged commit a1a3b87 into main Jan 27, 2025
26 checks passed
@akanpatel2206 akanpatel2206 deleted the user/akanpatel2206/OAuth2Manager_VelocityRemoval branch January 27, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants