-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BadgeNotification: Onboarding Unit tests to the pipeline test runs #5140
Merged
SatwikKrSharma
merged 2 commits into
main
from
user/satwiksharma/Onboarding_BadgeUT_To_Pipeline
Feb 17, 2025
Merged
BadgeNotification: Onboarding Unit tests to the pipeline test runs #5140
SatwikKrSharma
merged 2 commits into
main
from
user/satwiksharma/Onboarding_BadgeUT_To_Pipeline
Feb 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sharath2727
approved these changes
Feb 17, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
satkh
reviewed
Feb 17, 2025
@@ -21,7 +21,7 @@ | |||
<PublisherDisplayName>Windows APP SDK</PublisherDisplayName> | |||
<Logo>taef.png</Logo> | |||
</Properties> | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit : space
@@ -40,7 +40,7 @@ | |||
<None Include="packages.config" /> | |||
</ItemGroup> | |||
<ItemGroup> | |||
<ResourceCompile Include="AppNotificationTests.rc"> | |||
<ResourceCompile Include="BadgeNotificationTests.rc"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is AppNotificationTests , removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes involve onboarding unit tests for the BadgeNotification API to run as part of the pipeline test runs (Checkin, Nightly, and Release).
Testing - In the build pipeline all tests are passing
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.