test: add readiness checks to target page e2es before interacting with visualizations #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shobhit1
reviewed
Nov 26, 2019
| popupPage = await browser.newPopupPage(targetPage); | ||
| await popupPage.gotoAdhocPanel(); | ||
| await popupPage.enableToggleByAriaLabel('Tab stops'); | ||
|
|
||
| await targetPage.bringToFront(); | ||
| await targetPage.waitForShadowRoot(); |
dbjorge
added a commit
to dbjorge/accessibility-insights-web
that referenced
this pull request
Nov 26, 2019
smoralesd
pushed a commit
that referenced
this pull request
Dec 2, 2019
This purpose of this PR is to resolve #1591 by replacing our `manifest.json` permissions for `https://*/*", "http://*/*", "file://*/*` with the `activeTab` permission. To achieve this, it updates the way we track creation and update events for tabs such that we now: * treat opening the popup view (which gives our extension permissions for the currently-active tab for as long as it stays on the same origin) as "opening" that tab * treat tab updates/navigation events that change the origin of a tab as having "closed" that tab This PR only slightly changes the `target-page-controller` implementation, but its tests were a real challenge to follow originally, so the PR completely rewrites `target-page-controller.test.ts` (don't bother comparing them side-by-side, treat it as a new test file for the class). * refactor: rename Tab.Update and Tab.Change msgs to be distinguishable * consider origin change events to be like page close events * prettier format for manifest.json * Update popup-action-message-creator unit tests per changes * Update tab store onExistingTabUpdated tests to account for new branch * Update onNewTabCreated tests to account for new cases * Add PopupActionCreator tests * Rewrite target page controller tests (in-progress) * Refactor simualted browser adapter to separate file, finish test impl * Fix lint errors * use isFunction check on setup for addListener mocks * add tabToContextMap behavior to test corpus * adjust permission on runtime for e2e to be able to inject js/css into the target page * Fix merge conflict resolutions * Fix lint/format issues from merge conflicts * Add prerequisite "launch popup" step to details view e2e tests * Update adhoc-panel tests to simulate activeTab permissions * Fix issue where screenshotOnError would time out and break error stacks if evaluate took too long * Hacky workaround for adhoc-panel.test timeouts * Add puppeteer tracing around failing adhoc panel tests * Avoid issue with page mutation between different parts of clickSelector * Revert withTracing changes that were extracted to #1751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR aims to improve an e2e reliability issue that already existed but was exacerbated by #1717 (see motivating failure), where the tabstop tests attempt to interact with the tab stop visualization on the target page before they verify that the target page visualizations are in a ready state. With this PR:
Cleans up a little page controller method naming nearby as well.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). Check workflow guide at:<rootDir>/docs/workflow.md