Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Luminance Calculations #432

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Update Luminance Calculations #432

merged 1 commit into from
Jul 15, 2019

Conversation

DaveTryon
Copy link
Contributor

Describe the change

This changes the threshold for the relative luminance calculations, per #391.

PR checklist

  • Run through of all test scenarios completed?
  • Does this address an existing issue? If yes, Issue# - [BUG] Outdaded SrGB value calculation #391
  • Includes UI changes?
    • Run the production version of Accessibility Insights for Windows against a version with changes.
    • Attach any screenshots / GIF's that are applicable.

Note: After the PR has been created, certain checks will be kicked off. All of these checks must pass before a merge.

@DaveTryon DaveTryon requested a review from jalkire July 15, 2019 20:54
@DaveTryon DaveTryon requested a review from a team as a code owner July 15, 2019 20:54
@DaveTryon DaveTryon merged commit c34dd58 into microsoft:master Jul 15, 2019
@DaveTryon DaveTryon deleted the UpdateLuminanceCalculation branch July 15, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalkire jalkire jalkire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaveTryon @jalkire