.NET: fix: Update Concurrent sample for changes to message aggregation #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the concurrent workflow sample to rename the aggregation executor and change its message handling signature from single ChatMessage to List<ChatMessage>.
Key changes:
- Renamed
ConcurrentAggregationExecutortoConcurrentEndExecutorfor consistency with the internal framework implementation - Updated the executor's generic type parameter from
ChatMessagetoList<ChatMessage>to properly handle batched messages - Changed the message handling logic from
AddtoAddRangeto accommodate the new list-based input
dotnet/samples/GettingStarted/Workflows/Concurrent/Concurrent/Program.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/GettingStarted/Workflows/Concurrent/Concurrent/Program.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/GettingStarted/Workflows/Concurrent/Concurrent/Program.cs
Show resolved
Hide resolved
lokitoth
force-pushed
the
dev/dotnet_workflow/fix_concurrent_workflow_sample
branch
from
61a0141 to
62fc736
Compare
alliscode
approved these changes
Nov 3, 2025
Member
Author
|
Pulled into #1612 |
crickman
deleted the
dev/dotnet_workflow/fix_concurrent_workflow_sample
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We updated the aggregation logic for
AIAgent's outgoingChatMessagesin #1439; this changes the messages that get received by the aggregating executor in the sample fromChatMessagetoList<ChatMessage>, which was resulting in their getting dropped when going across the edge (except in telemetry).Description
The fix is to update the
ConcurrentAggregatingExecutorto processList<ChatMessage>. In the long run, the proper fix is to ensure that (1) fan-in properly understands ChatProtocol via different reduction strategies, and (2) to make the output for hostedAIAgentmore configurable - both in the streaming and non-streaming case.This fixes the immediate problem that has been driving issues, but the underlying need to make FanIn more configurable so it can work well with ChatProtocol still remains.
Relevant issues:
Closes #1863
Closes #1805
Contribution Checklist
Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.