Skip to content

.NET: Comment on DevUI middleware redirectUrl #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeagleGross merged 2 commits into from
Dec 11, 2025
Merged

.NET: Comment on DevUI middleware redirectUrl #2723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebf8052
code ql sm04598
DeagleGross Dec 9, 2025
4297e3e
Merge branch 'main' into dmkorolev/url-redirect-codeql
markwallace-microsoft Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/Microsoft.Agents.AI.DevUI/DevUIMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public async Task HandleRequestAsync(HttpContext context)
}

context.Response.StatusCode = StatusCodes.Status301MovedPermanently;
context.Response.Headers.Location = redirectUrl;
context.Response.Headers.Location = redirectUrl; // CodeQL [SM04598] justification: The redirect URL is constructed from a server-configured base path (_basePath), not user input. The query string is only appended as parameters and cannot change the redirect destination since this is a relative URL.

this._logger.LogDebug("Redirecting {OriginalPath} to {RedirectUrl}", NewlineRegex().Replace(path, ""), NewlineRegex().Replace(redirectUrl, ""));
return;
Expand Down
Loading