-
Notifications
You must be signed in to change notification settings - Fork 1.1k
.NET: fix: FileSystemJsonCheckpointStore does not flush to disk on Checkpoint creation #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lokitoth
merged 1 commit into
main
from
dev/dotnet_workflow/fix_filesystemcheckpointstore_does_not_flush
Jan 27, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/FileSystemJsonCheckpointStoreTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
|
|
||
| using System; | ||
| using System.IO; | ||
| using System.Text.Json; | ||
| using System.Threading.Tasks; | ||
| using FluentAssertions; | ||
| using Microsoft.Agents.AI.Workflows.Checkpointing; | ||
|
|
||
| namespace Microsoft.Agents.AI.Workflows.UnitTests; | ||
|
|
||
| public sealed class FileSystemJsonCheckpointStoreTests | ||
| { | ||
| [Fact] | ||
| public async Task CreateCheckpointAsync_ShouldPersistIndexToDiskBeforeDisposeAsync() | ||
| { | ||
| // Arrange | ||
| DirectoryInfo tempDir = new(Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString())); | ||
| FileSystemJsonCheckpointStore? store = null; | ||
|
|
||
| try | ||
| { | ||
| store = new(tempDir); | ||
| string runId = Guid.NewGuid().ToString("N"); | ||
| JsonElement testData = JsonSerializer.SerializeToElement(new { test = "data" }); | ||
|
|
||
| // Act | ||
| CheckpointInfo checkpoint = await store.CreateCheckpointAsync(runId, testData); | ||
|
|
||
| // Assert - Check the file size before disposing to verify data was flushed to disk | ||
| // The index.jsonl file is held exclusively by the store, so we check via FileInfo | ||
| string indexPath = Path.Combine(tempDir.FullName, "index.jsonl"); | ||
| FileInfo indexFile = new(indexPath); | ||
| indexFile.Refresh(); | ||
| long fileSizeBeforeDispose = indexFile.Length; | ||
|
|
||
| // Data should already be on disk (file size > 0) before we dispose | ||
| fileSizeBeforeDispose.Should().BeGreaterThan(0, "index.jsonl should be flushed to disk after CreateCheckpointAsync"); | ||
|
|
||
| // Dispose to release file lock before final verification | ||
| store.Dispose(); | ||
| store = null; | ||
|
|
||
| string[] lines = File.ReadAllLines(indexPath); | ||
| lines.Should().HaveCount(1); | ||
| lines[0].Should().Contain(checkpoint.CheckpointId); | ||
| } | ||
| finally | ||
| { | ||
| store?.Dispose(); | ||
| if (tempDir.Exists) | ||
| { | ||
| tempDir.Delete(recursive: true); | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.