.NET: Address RunAsync Extensions Option 2 #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes extension methods for ChatClientAgent to address ambiguity between AgentRunOptions and ChatOptions parameters, following recommendation from issue #521.
- Complete removal of ChatClientAgentExtensions class and its extension methods
- Deletion of all corresponding unit tests for the extension methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ChatClientAgentExtensions.cs |
Removes entire extensions class with RunAsync and RunStreamingAsync methods |
ChatClientAgentExtensionsTests.cs |
Removes all unit tests that were validating the extension methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
markwallace-microsoft
approved these changes
Sep 5, 2025
SergeyMenshykh
approved these changes
Sep 5, 2025
ReubenBond
pushed a commit
to ReubenBond/agent-framework
that referenced
this pull request
Oct 28, 2025
Arturo-Quiroga-MSFT
pushed a commit
to Arturo-Quiroga-MSFT/agent-framework-public
that referenced
this pull request
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Following the recommendation in the issue
Sounds reasonable the full removal of the extensions to address ambiguity between.
AgentRunOptionsandChatOptions.Interstingly enough, the extensions where not being used anywhere in the code, which makes the case stronger for removal.