Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMPLE] Smart Text Box control #135

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[SAMPLE] Smart Text Box control #135

wants to merge 11 commits into from

Conversation

zateutsch
Copy link
Contributor

fixes #131

Added smart text box control sample.

@zateutsch zateutsch requested a review from nmetulev January 28, 2025 19:06
Copy link
Member

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Only suggestion here is make sure that using ctrl + a to select all text should also invoke the flyout.

AIDevGallery/Samples/SharedCode/SmartTextBox.cs Outdated Show resolved Hide resolved
@nmetulev nmetulev requested a review from Copilot January 29, 2025 19:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.

Files not reviewed (4)
  • AIDevGallery/App.xaml: Language not supported
  • AIDevGallery/Samples/Open Source Models/Language Models/SmartText.xaml: Language not supported
  • AIDevGallery/Samples/SharedCode/SmartTextBox.xaml: Language not supported
  • AIDevGallery/Samples/scenarios.json: Language not supported
Comments suppressed due to low confidence (1)

AIDevGallery/Samples/SharedCode/SmartTextBox.cs:243

  • Using Task.Run is unnecessary and can be simplified to just await DescribeChanges(textToChange, changes);
return await Task<string>.Run(async () =>

@zateutsch zateutsch requested a review from nmetulev January 30, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SAMPLE] Add SmartTextbox control
3 participants