fix: check top-level instruction field for agent .md file instructions#55
Merged
fix: check top-level instruction field for agent .md file instructions#55
Conversation
Companion fix to amplifier-foundation change. The session spawner now checks for instruction at the top level (from agent .md file body) first, then falls back to the nested system.instruction path. This ensures agent instructions from .md files are properly injected into spawned agent sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion fix to amplifier-foundation PR that ensures agent instructions from .md files are properly used when spawning agent sessions.
Problem
The session spawner was only checking
agent_config.get("system", {}).get("instruction")for the agent's system instruction. However, when agent instructions come from the markdown body of agent.mdfiles, they are now exposed at the top level asinstruction(after the foundation fix).Solution
Updated
session_spawner.pyto check forinstructionat the top level first, then fall back to the nestedsystem.instructionpath:Related