fix: use HookRegistry.emit() instead of non-existent .fire()#32
Open
Joi wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: use HookRegistry.emit() instead of non-existent .fire()#32Joi wants to merge 1 commit intomicrosoft:mainfrom
Joi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The HookRegistry class in amplifier-core exposes emit() for firing hook events, but executor.py was calling hooks.fire() which does not exist. This causes an AttributeError on every recipe execution: AttributeError: 'HookRegistry' object has no attribute 'fire' Change the call to hooks.emit() to match the actual API. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributeError: 'HookRegistry' object has no attribute 'fire'that breaks all recipe executionHookRegistryclass in amplifier-core exposesemit()for firing hook events, butexecutor.pywas calling the non-existenthooks.fire()hooks.fire(event_name, event_data)→hooks.emit(event_name, event_data)Details
In
modules/tool-recipes/amplifier_module_tool_recipes/executor.py(line 272), the recipe executor dispatches structured hook events for UI integration (e.g., Canvas). The call usedhooks.fire(), which does not exist on theHookRegistryclass — the correct method ishooks.emit().This causes every recipe execution to crash with:
Test plan
AttributeErroron hook dispatch🤖 Generated with Amplifier