Add support for NUnit3 XML reports from UITest #572
Conversation
| const testSuitesParent: Element = this.collectAllElements(xml1.documentElement, "test-run")[0]; | ||
| const testSuites: Element[] = this.collectChildren(xml2.documentElement, "test-suite"); | ||
|
|
||
| testSuites.forEach((child: Element) => { |
There was a problem hiding this comment.
I think you can use the spread operator here to make the code simpler to read:
testSuitesParent.append(...testSuites)
There was a problem hiding this comment.
I couldn't get this to work:
.appendChild isn't compatible with ... because it expects at least 1 child element this error gets raised
.append appears to not work for an Element which is confusing. Unless you're super keen for me to do this I suggest we don't invest too much time in it.
| } | ||
|
|
||
| isNUnit3(xml: Document): boolean { | ||
| const testResults: Element[] = this.collectAllElements(xml.documentElement, "test-results"); |
There was a problem hiding this comment.
this is more of a not nunit2 test. Perhaps its better to test for precense of "test-run" instead of absence of "test-results"
There was a problem hiding this comment.
I've done it like this pending NUnit4 coming out so that it's easier to convert to:
getNUnitVersion: int
Or something similar. Although it might not be the case, I figured NUnit4 is more likely to follow similar report format the NUnit3 - at which point we may need to dig in to the engine-version attribute on the test-results node.
|
@john7doe - I've not done 2 of your suggestions - let's discuss tomorrow if you think they're important enough to do! |
|
Merging despite CI build error - will handle that separately. |
Motivation
NUnit3test runs against the latestUITestfail when they attempt to merge the output XML (this is because of a bug in the merging on the pipeline but also because of the code here which needed updating to match).This PR adds support for the new
NUnit3report format.Caveat
Looking at the existing code, I suspect that there are some issues merging result states between test runs (both in
NUnit2andNUnit3) - I have not had time to investigate this thoroughly but I believe it would manifest if running on several devices and only a subset of the devices fail.Example CLI output:
@maxxkrakoa - I'm not sure who's best to review this PR. Normally I'd ask Simon - let me know!