Fix crash when direct boot #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandr-dorofeev
requested review from
AnatolyPristensky,
AlexeyBudynkov,
DmitriyKirakosyan and
MatkovIvan
MatkovIvan
suggested changes
Jun 10, 2022
sdk/appcenter/src/main/java/com/microsoft/appcenter/ApplicationContextUtils.java
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/ApplicationContextUtilsTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/ApplicationContextUtilsTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/ApplicationContextUtilsTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/ApplicationContextUtilsTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/ApplicationContextUtilsTest.java
Outdated
Show resolved
Hide resolved
|
@aleksandr-dorofeev I think we should also modify the existing test(s) of AppCenter.run and check that we use context from |
MatkovIvan
suggested changes
Jun 14, 2022
sdk/appcenter/src/test/java/com/microsoft/appcenter/AbstractAppCenterTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/AbstractAppCenterTest.java
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/AppCenterTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/AppCenterTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/AppCenterTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/AppCenterTest.java
Outdated
Show resolved
Hide resolved
sdk/appcenter/src/test/java/com/microsoft/appcenter/AppCenterTest.java
Outdated
Show resolved
Hide resolved
aleksandr-dorofeev
force-pushed
the
fix/protected-context
branch
from
eac5ccb to
4c74308
Compare
MatkovIvan
reviewed
Jun 15, 2022
AlexeyBudynkov
previously approved these changes
Jun 15, 2022
MatkovIvan
reviewed
Jun 16, 2022
sdk/appcenter/src/test/java/com/microsoft/appcenter/ApplicationContextUtilsTest.java
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Jun 20, 2022
DmitriyKirakosyan
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdbeen updated?[ ] Did you check UI tests on the sample app? They are not executed on CI.Description
Added protected storage for data in direct boot mode.
Related PRs or issues
#1599
AB#91315