Add Catalyst support to Analytics #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastasiaKubova
force-pushed
the
feature/analytics-catalyst
branch
from
f707d8d to
56230d5
Compare
Codecov Report
@@ Coverage Diff @@
## feature/support-catalyst #2057 +/- ##
=========================================================
Coverage 91.63% 91.63%
=========================================================
Files 129 129
Lines 10072 10072
=========================================================
Hits 9229 9229
Misses 843 843
Continue to review full report at Codecov.
|
MatkovIvan
suggested changes
May 18, 2020
AppCenterAnalytics/AppCenterAnalytics.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
May 18, 2020
AnastasiaKubova
force-pushed
the
feature/analytics-catalyst
branch
from
854b67d to
2fbbc01
Compare
AnastasiaKubova
force-pushed
the
feature/analytics-catalyst
branch
from
2fbbc01 to
396fa61
Compare
Codecov Report
@@ Coverage Diff @@
## feature/support-catalyst #2057 +/- ##
============================================================
- Coverage 91.38% 91.30% -0.08%
============================================================
Files 113 113
Lines 8413 8431 +18
============================================================
+ Hits 7688 7698 +10
- Misses 725 733 +8
Continue to review full report at Codecov.
|
AnastasiaKubova
changed the base branch from
feature/support-catalyst
to
feature/catalyst-tests
MatkovIvan
suggested changes
May 19, 2020
| #elif TARGET_OS_MACCATALYST | ||
| // This returns scale value based on scale values iOS. | ||
| // So we need to use base value for macOS. | ||
| CGFloat scale = 3; |
There was a problem hiding this comment.
Move magic numbers to consts
…appcenter-sdk-apple into feature/core-catalyst # Conflicts: # AppCenter/AppCenter/Internals/Util/MSUtility.m
…ture/core-catalyst
tvOS 11 is a minimum supported in the SDK version.
# Conflicts: # AppCenter/AppCenterTests/MSDeviceTrackerTests.m
AnastasiaKubova
changed the base branch from
feature/catalyst-tests
to
feature/core-catalyst
added 11 commits
May 20, 2020 09:23
Base automatically changed from
feature/core-catalyst
to
feature/support-catalyst
May 20, 2020 10:49
…eature/analytics-catalyst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to consider before you submit the PR:
HasCHANGELOG.mdbeen updated?Did you add unit tests?Did you check UI tests on the sample app? They are not executed on CI.Description
In Catalyst project for macOS and for native macOS we have different sending data in analytics reports.
Different screen size
Was: “screenSize” : “1800x2880",
Now: “screenSize” : “1200x1920"
Different model name (now just numbers)
Was: “MacBookPro15,2”,
Now: x86_64
Different OS name:
Was: “osName” : “macOS”,
Now: “osName” : “Mac OS X”
Related PRs or issues
AB#79044