Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catalyst support to Core #2058

Merged
merged 22 commits into from
May 20, 2020

Conversation

AnastasiaKubova
Copy link

@AnastasiaKubova AnastasiaKubova commented May 18, 2020

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Add check for TARGET_OS_MACCATALYST where need and make sure that all test passed.

Related PRs or issues

AB#79046

AppCenter/AppCenter.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Scripts/VerifyNoBuildSettings.swift Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented May 18, 2020

Codecov Report

Merging #2058 into feature/support-catalyst will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feature/support-catalyst    #2058   +/-   ##
=========================================================
  Coverage                     91.63%   91.63%           
=========================================================
  Files                           129      129           
  Lines                         10072    10072           
=========================================================
  Hits                           9229     9229           
  Misses                          843      843           
Flag Coverage Δ
#iOS 91.64% <100.00%> (-0.27%) ⬇️
#macOS 91.62% <100.00%> (ø)
#tvOS 91.04% <100.00%> (-0.33%) ⬇️
Impacted Files Coverage Δ
...ternals/DelegateForwarder/MSAppDelegateForwarder.m 81.96% <100.00%> (ø)
...Center/AppCenter/Internals/Util/MSDispatcherUtil.m 100.00% <100.00%> (ø)
...r/AppCenter/Internals/Util/MSUtility+Environment.m 18.75% <100.00%> (ø)
...ppCenter/AppCenter/Internals/Util/MSUtility+File.m 90.75% <100.00%> (ø)
...er/Internals/Vendor/Reachability/MS_Reachability.m 61.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1364f5...1647136. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #2058 into feature/catalyst-tests will decrease coverage by 0.32%.
The diff coverage is 82.60%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feature/catalyst-tests    #2058      +/-   ##
==========================================================
- Coverage                   91.63%   91.30%   -0.33%     
==========================================================
  Files                         129      113      -16     
  Lines                       10072     8431    -1641     
==========================================================
- Hits                         9229     7698    -1531     
+ Misses                        843      733     -110     
Flag Coverage Δ
#iOS ?
#macOS 91.54% <80.95%> (-0.08%) ⬇️
#tvOS 90.96% <80.95%> (-0.09%) ⬇️
Impacted Files Coverage Δ
AppCenter/AppCenter/Internals/Util/MSUtility.m 56.00% <55.55%> (-1.15%) ⬇️
...pCenter/Internals/Context/Device/MSDeviceTracker.m 92.72% <100.00%> (+0.38%) ⬆️
...enter/Internals/Context/Session/MSSessionContext.m 100.00% <100.00%> (ø)
...pCenter/Internals/Context/UserId/MSUserIdContext.m 100.00% <100.00%> (ø)
...ternals/DelegateForwarder/MSAppDelegateForwarder.m 59.01% <100.00%> (-22.96%) ⬇️
...enter/AppCenter/Internals/Storage/MSLogDBStorage.m 94.69% <100.00%> (-0.06%) ⬇️
...ppCenter/AppCenter/Internals/Util/MSUtility+File.m 90.75% <100.00%> (ø)
AppCenter/AppCenter/Internals/Util/MSUtility.h 100.00% <100.00%> (ø)
...er/Internals/Vendor/Reachability/MS_Reachability.m 61.06% <100.00%> (ø)
AppCenter/AppCenter/MSAppCenter.m 94.58% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71532d5...1f0a490. Read the comment docs.

@AnastasiaKubova AnastasiaKubova force-pushed the feature/core-catalyst branch from 4be69ee to aa005ee Compare May 19, 2020 06:38
@AnastasiaKubova AnastasiaKubova changed the base branch from feature/support-catalyst to feature/catalyst-tests May 19, 2020 09:13
@AnastasiaKubova AnastasiaKubova marked this pull request as ready for review May 20, 2020 06:34
@annakocheshkova annakocheshkova changed the base branch from feature/catalyst-tests to feature/support-catalyst May 20, 2020 10:45
@annakocheshkova
Copy link

Comments will be addressed separately.

@annakocheshkova annakocheshkova merged commit ba959bf into feature/support-catalyst May 20, 2020
@annakocheshkova annakocheshkova deleted the feature/core-catalyst branch May 20, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants