Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Catalyst #2061

Merged
merged 6 commits into from
May 19, 2020
Merged

Conversation

russelarms
Copy link
Contributor

Things to consider before you submit the PR:

  • [ ] Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • [ ] Did you add unit tests?
  • [ ] Did you check UI tests on the sample app? They are not executed on CI.
  • [ ] Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

  • Remove OCHamcrest binaries and add OCHamcrest as a submodule.
  • Add OCHamcrest as a sub project to be build it for Mac Catalyst.
  • Fix tests in Core for iOS and Catalyst.

Related PRs or issues

AB#79052

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #2061 into feature/support-catalyst will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feature/support-catalyst    #2061   +/-   ##
=========================================================
  Coverage                     91.63%   91.63%           
=========================================================
  Files                           129      129           
  Lines                         10072    10072           
=========================================================
  Hits                           9229     9229           
  Misses                          843      843           
Flag Coverage Δ
#iOS 91.91% <100.00%> (ø)
#macOS 91.62% <100.00%> (ø)
#tvOS 91.04% <100.00%> (-0.33%) ⬇️
Impacted Files Coverage Δ
...r/AppCenter/Internals/Util/MSUtility+Environment.m 18.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9d8be...71532d5. Read the comment docs.

@russelarms russelarms requested a review from MatkovIvan May 19, 2020 10:54
Copy link
Contributor

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra references with local paths

@russelarms russelarms merged commit d03d5c1 into feature/support-catalyst May 19, 2020
@MatkovIvan MatkovIvan deleted the feature/catalyst-tests branch May 21, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants