Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalyst feedback and fixes #2066

Merged

Conversation

AnastasiaKubova
Copy link

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Resolve feedback.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #2066 into feature/support-catalyst will decrease coverage by 0.07%.
The diff coverage is 81.81%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feature/support-catalyst    #2066      +/-   ##
============================================================
- Coverage                     91.38%   91.30%   -0.08%     
============================================================
  Files                           113      113              
  Lines                          8413     8429      +16     
============================================================
+ Hits                           7688     7696       +8     
- Misses                          725      733       +8     
Flag Coverage Δ
#macOS 91.54% <80.48%> (-0.09%) ⬇️
#tvOS 90.96% <79.48%> (-0.09%) ⬇️
Impacted Files Coverage Δ
AppCenter/AppCenter/Internals/Util/MSUtility.h 100.00% <ø> (ø)
AppCenter/AppCenter/Internals/Util/MSUtility.m 56.00% <55.55%> (-1.15%) ⬇️
...pCenter/Internals/Context/Device/MSDeviceTracker.m 92.72% <100.00%> (+0.03%) ⬆️
...enter/Internals/Context/Session/MSSessionContext.m 100.00% <100.00%> (ø)
...pCenter/Internals/Context/UserId/MSUserIdContext.m 100.00% <100.00%> (ø)
...ternals/DelegateForwarder/MSAppDelegateForwarder.m 59.01% <100.00%> (ø)
...enter/AppCenter/Internals/Storage/MSLogDBStorage.m 94.69% <100.00%> (-0.06%) ⬇️
...ppCenter/AppCenter/Internals/Util/MSUtility+File.m 90.75% <100.00%> (ø)
...er/Internals/Vendor/Reachability/MS_Reachability.m 61.06% <100.00%> (ø)
...lytics/TransmissionTarget/MSPropertyConfigurator.m 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c755766...2c255bb. Read the comment docs.

@AnastasiaKubova AnastasiaKubova marked this pull request as ready for review May 20, 2020 12:54
@annakocheshkova annakocheshkova merged commit 50b3958 into feature/support-catalyst May 21, 2020
@annakocheshkova annakocheshkova deleted the feature/catalyst-resolve-feedback branch May 21, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants