Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Support file rather than env based scheme to acquire policy, uvm info and certs. #23

Merged
merged 10 commits into from
Apr 19, 2023

Conversation

KenGordon
Copy link
Contributor

@KenGordon KenGordon commented Apr 6, 2023

Support file rather than env based scheme to acquire policy, uvm info and certs.

To match microsoft/hcsshim#1708

This PR supports both methods to decouple testing/deployment. There will be a subsequent PR to remove support for the environment variable scheme.

This PR also includes a debug version of the skr container that allows ssh-ing into the containers for debugging purposes.

…and certs.

Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
@KenGordon KenGordon changed the title Support file rather than env based scheme to aquire policy, uvm info … Support file rather than env based scheme to aquire policy, uvm info and certs. Apr 6, 2023
@KenGordon KenGordon changed the title Support file rather than env based scheme to aquire policy, uvm info and certs. Support file rather than env based scheme to acquire policy, uvm info and certs. Apr 6, 2023
@KenGordon KenGordon requested a review from svolos April 6, 2023 11:23
pkg/common/info.go Outdated Show resolved Hide resolved
pkg/common/info.go Outdated Show resolved Hide resolved
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
@KenGordon KenGordon marked this pull request as ready for review April 19, 2023 14:54
Copy link
Contributor

@svolos svolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR's functionality has been tested by running the skr example on clusters that pass the uvm information via files or env. variables.

Signed-off-by: Ken Gordon <ken.gordon@microsoft.com>
@KenGordon KenGordon merged commit 1d09a65 into main Apr 19, 2023
@KenGordon KenGordon deleted the ken/envs_to_files branch April 19, 2023 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants