Fix link for referencing existing SQL Server resources #198
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -71,7 +71,7 @@ The name of the parameter is `sql-password`, but really it's just formatting the | |||||
| The `WithReference` method configures a connection in the `ExampleProject` named `database`. | ||||||
|
|
||||||
| <Aside type="tip"> | ||||||
| If you'd rather connect to an existing SQL Server, call `AddConnectionString` instead. For more information, see [Reference existing resources](../../fundamentals/external-parameters/#connection-string-values). | ||||||
|
There was a problem hiding this comment. There's another instance of the same broken link in efcore/sql-server.mdx at line 74 that also references the non-existent app-host-overview.md file. This file should be updated with the same fix for consistency.
Suggested change
Author
There was a problem hiding this comment. The |
||||||
| </Aside> | ||||||
|
|
||||||
| ### Add SQL Server resource with database scripts | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new link points to the "Connection string values" section which is appropriate for the AddConnectionString method. However, other similar documentation pages (mysql.mdx, oracle.mdx, mongodb.mdx) use a different link: /get-started/resources/ for the same purpose. For consistency across the documentation, consider using the same link pattern. The /get-started/resources/ page provides a higher-level overview of working with resources, while external-parameters focuses specifically on connection strings—both are relevant, but consistency would help users navigate the docs more predictably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe the
/get-started/resources/is an appropriate link. It does not provide additional guidance for how to best utilizeAddConnectionString.