Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bug when using anthropic bedrock #3198

Closed
Au233 opened this issue Jul 24, 2024 · 3 comments
Closed

[Bug]: Bug when using anthropic bedrock #3198

Au233 opened this issue Jul 24, 2024 · 3 comments
Assignees
Labels
models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)

Comments

@Au233
Copy link

Au233 commented Jul 24, 2024

Describe the bug

Hi, I cloned the latest version of your autogen repository and packaged it for use, to utilize the newly added Anthropics Bedrock interface. I discovered several bugs during the process, which I would like to provide for your reference:
(1) Regarding the configuration file of Anthropics Bedrock , aws_session_token is not mandatory. Therefore, in line 111 of the code located at ./autogen/autogen/oai/anthropic.py, it is unnecessary to check its value.
(2) In line 490 of /maindata/data/user/qiaoqiao.jin/3DGPT/autogen/autogen/oai/client.py, the input should be config instead of openai_config, as openai_config is None at that point.

Steps to reproduce

No response

Model Used

No response

Expected Behavior

No response

Screenshots and logs

No response

Additional Information

No response

@Au233 Au233 added the bug label Jul 24, 2024
@Hk669
Copy link
Contributor

Hk669 commented Jul 24, 2024

@Au233 thanks for spotting the bug. making a PR on this. feel free to review it and let us know your thoughts. thanks

@Hk669 Hk669 added the models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.) label Jul 24, 2024
@Hk669 Hk669 self-assigned this Jul 24, 2024
@Zizo-Vi
Copy link
Contributor

Zizo-Vi commented Jul 24, 2024

I have submit a PR: #3200 for this issue. Please review.

@marklysze
Copy link
Collaborator

Hi all, @Hk669, @Au233, @wenngong - I'll close this as #3210 has been merged. Please re-open if it is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants