-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OAI]: Fix Anthropic Bedrock Client Bug #3200
Conversation
thanks @wenngong , was about to make a PR, made changes locally. |
Ok, I will fix it. |
@microsoft-github-policy-service agree |
@Hk669 I have fixed the test failure. and pre-commit passed. Please review. |
but the anthropic, shouldnt be in the required dependencies, can you please check on that. |
OAI_CONFIG_LIST config file example:
|
@wenngong this seems to be a good PR, can you please check this #3210 |
@Hk669 I really think do not scatter bedrock related kwargs to client.py,they should be kept in AnthropicClient. |
@@ -370,7 +370,8 @@ class OpenAIWrapper: | |||
|
|||
openai_kwargs = set(inspect.getfullargspec(OpenAI.__init__).kwonlyargs) | |||
aopenai_kwargs = set(inspect.getfullargspec(AzureOpenAI.__init__).kwonlyargs) | |||
openai_kwargs = openai_kwargs | aopenai_kwargs | |||
anthropic_kwargs = set(inspect.getfullargspec(AnthropicClient.__init__).args) | |||
openai_kwargs = openai_kwargs | aopenai_kwargs | anthropic_kwargs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is not intuitive: should openai_kwargs contain anthropic_kwargs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe #3210 fixes this issue.
@wenngong thanks for the efforts. this issue is fixed in the other PR. |
Fix #3198
Checks