GroupChatManager don't work with async functions registered with register_reply

[bonadio]

Hi

I have a web integration with Autogen which uses asyncio
https://github.com/bonadio/autogenwebdemo

If I try to use GroupChatManager my UI never gets updated.
the problem is that GroupChatManager only calls the synchronous version of "generate_reply" after selecting the speaker

speaker = groupchat.select_speaker(speaker, self)
reply = speaker.generate_reply(sender=self)

this synchronous version ignores any async function registered with register_reply

would be nice to have an async version. I think if we have a GroupChatManager.run_chat and a GroupChatManager.a_run_chat it would work. I have a async version example here https://github.com/bonadio/autogenwebdemo/blob/main/backend/src/groupchatweb.py

If this is the correct way I could create a PR to that.

Thanks

[sonichi]

@bonadio could you check whether #87 is the right solution?
@gagb @victordibia you seemed to have done a test with #87 for group chat. Please also chime in.

[bonadio]

@bonadio could you check whether #87 is the right solution? @gagb @victordibia you seemed to have done a test with #87 for group chat. Please also chime in.

Hi @sonichi I tested and it works.
my only concern about that solution is some edge case where the code could run the synchronous function too, what in my case would not be good.

One approach I thought was to add a parameter to the constructor async=True and register the correct version

[sonichi]

Thanks. #87 has been merged. @gagb is probably going to make a PR to add a test case. Could you follow up with @gagb to also add your test case and if needed, figure out a solution to cover it?

[gagb]

Thanks. #87 has been merged. @gagb is probably going to make a PR to add a test case. Could you follow up with @gagb to also add your test case and if needed, figure out a solution to cover it?

Yes, I will be adding those in #517

[gagb]

Thanks. #87 has been merged. @gagb is probably going to make a PR to add a test case. Could you follow up with @gagb to also add your test case and if needed, figure out a solution to cover it?

Yes, I will be adding those in #517

@bonadio does the notebook in #520 help?

[thinkall]

We are closing this issue due to inactivity; please reopen if the problem persists.