Let run tests directly via python test_xyz.py, fix for conftest import via sys.path.append

[maxim-saplin]

I have added sys.path.append() before all from conftest import skip_openai and also checked the test can be run directly.

Related issue number

Closes #1120 and #1137

Checks

• [N/A] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
• [N/A] I've added tests (if relevant) corresponding to the changes introduced in this PR.
• I've made sure all auto checks have passed.

[rickyloynd-microsoft]

Awesome!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (871e9e2) 30.74% compared to head (731cd55) 40.39%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
+ Coverage   30.74%   40.39%   +9.64%     
==========================================
  Files          30       30              
  Lines        4043     4043              
  Branches      915      964      +49     
==========================================
+ Hits         1243     1633     +390     
+ Misses       2721     2299     -422     
- Partials       79      111      +32     

Flag	Coverage Δ
unittests	40.31% <ø> (+9.62%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[afourney]

I think this is generally fine.

I think it's worth considering in the future how we maybe restructure the tests directory to maybe ameliorate this, and the need to add both the parent and grandparent paths.

Adding so many non-standard system paths feels a little suboptimal.

[maxim-saplin]

I think this is generally fine.

I think it's worth considering in the future how we maybe restructure the tests directory to maybe ameliorate this, and the need to add both the parent and grandparent paths.

Adding so many non-standard system paths feels a little suboptimal.

Totally agree and I don't like the smell of the PR :)

IMO it is better to drop the requirement to have the tests runnable by theirselves and revert to tooling (such as PyTest or IDE) - this will also allow to avoid adding main part at the bottom of files

[rickyloynd-microsoft]

to avoid adding main part at the bottom of files

For me, the main part is a convenient way of selecting just the functions I want to run manually, without having to be in the IDE, or having to run pytest.

[afourney]

@rickyloynd-microsoft Yes, it's a pain (and not always ideal possible) to run every test in the file when trying to iterate on, or develop, one specific test (e.g. that you are adding for a new PR or something). Obviously we want to run ALL tests before committing, but it's not necessary when trying to step through or debug one particular one.