Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix website production css #1366

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

cheng-tan
Copy link
Contributor

Why are these changes needed?

  • Docusaurus production doesn't support nested css(Can't use CSS nesting in prod facebook/docusaurus#9303) adding in postcss plugin to compile the modern css to support older version browsers.
  • Cleaned up the custom.css file a bit more and fixed two additional accessibility issue

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05923a7) 32.45% compared to head (1baef35) 32.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   32.45%   32.45%           
=======================================
  Files          41       41           
  Lines        4905     4905           
  Branches     1119     1119           
=======================================
  Hits         1592     1592           
  Misses       3187     3187           
  Partials      126      126           
Flag Coverage Δ
unittests 32.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cheng-tan.
Looking good. Will double check that things compile successfully and then finalize my review

@victordibia
Copy link
Collaborator

victordibia commented Jan 22, 2024

I confirm I have tested this.
I really appreciate the updates to contrast that this fixes.

@sonichi , @qingyun-wu , I believe this is ready for merging.

image

@victordibia victordibia self-requested a review January 22, 2024 20:23
@sonichi sonichi added this pull request to the merge queue Jan 23, 2024
Merged via the queue into microsoft:main with commit c76dc2b Jan 23, 2024
19 checks passed
quantum-ciphers pushed a commit to quantum-ciphers/autogen that referenced this pull request Jan 26, 2024
* fix website production css

* add yarn.lock
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
* fix website production css

* add yarn.lock
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix website production css

* add yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants