Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bind_dir arg to DockerCommandLineExecutor + docs update #2309

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

gbrvalerio
Copy link
Contributor

Why are these changes needed?

When the user wants deploy an application to a scenario in which the main app runs in a docker container that executes code using the DockerCommandLineExecutor, only binding the docker.sock is not enough. If the spawned container needs file access from the host, the check that the constructor method of the DockerCommandLineExecutor cli does to work_dir prevents this from happening. Adding a new bind_dir argument solves this without breaking old code and allows for such behavior to be supported.

Related issue number

Checks

@gbrvalerio
Copy link
Contributor Author

@microsoft-github-policy-service agree

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.05%. Comparing base (4a44093) to head (6647298).
Report is 328 commits behind head on main.

Files Patch % Lines
autogen/coding/docker_commandline_code_executor.py 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2309       +/-   ##
===========================================
+ Coverage   38.14%   50.05%   +11.91%     
===========================================
  Files          78       78               
  Lines        7865     7873        +8     
  Branches     1683     1824      +141     
===========================================
+ Hits         3000     3941      +941     
+ Misses       4615     3600     -1015     
- Partials      250      332       +82     
Flag Coverage Δ
unittest 14.22% <25.00%> (?)
unittests 49.02% <50.00%> (+10.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Apr 30, 2024
Merged via the queue into microsoft:main with commit a0fffc8 Apr 30, 2024
60 of 72 checks passed
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants