feat: add bind_dir arg to DockerCommandLineExecutor + docs update #2309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When the user wants deploy an application to a scenario in which the main app runs in a docker container that executes code using the
DockerCommandLineExecutor
, only binding thedocker.sock
is not enough. If the spawned container needs file access from the host, the check that the constructor method of the DockerCommandLineExecutor cli does to work_dir prevents this from happening. Adding a new bind_dir argument solves this without breaking old code and allows for such behavior to be supported.Related issue number
Checks