Skip to content

Fix tmp dir not exists #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkall merged 4 commits into from
Oct 24, 2023
Merged

Fix tmp dir not exists #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab41252
Fix tmp dir not exists
thinkall Oct 24, 2023
09cde16
Merge branch 'main' into fix_tmp_dir
thinkall Oct 24, 2023
8fdb9bc
Update tests to make it more clear
thinkall Oct 24, 2023
2da9964
Add check if save path is not None
thinkall Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions autogen/retrieve_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,10 @@ def get_files_from_dir(dir_path: Union[str, List[str]], types: list = TEXT_FORMA
def get_file_from_url(url: str, save_path: str = None):
"""Download a file from a URL."""
if save_path is None:
os.makedirs("/tmp/chromadb", exist_ok=True)
save_path = os.path.join("/tmp/chromadb", os.path.basename(url))
else:
os.makedirs(os.path.dirname(save_path), exist_ok=True)
with requests.get(url, stream=True) as r:
r.raise_for_status()
with open(save_path, "wb") as f:
Expand Down
4 changes: 2 additions & 2 deletions test/test_retrieve_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def query_vector_db(
db = lancedb.connect(db_path)
table = db.open_table("my_table")
query = table.search(vector).where(f"documents LIKE '%{search_string}%'").limit(n_results).to_df()
return {"ids": query["id"].tolist(), "documents": query["documents"].tolist()}
return {"ids": [query["id"].tolist()], "documents": [query["documents"].tolist()]}

def retrieve_docs(self, problem: str, n_results: int = 20, search_string: str = ""):
results = self.query_vector_db(
Expand All @@ -166,7 +166,7 @@ def retrieve_docs(self, problem: str, n_results: int = 20, search_string: str =

create_lancedb()
ragragproxyagent.retrieve_docs("This is a test document spark", n_results=10, search_string="spark")
assert ragragproxyagent._results["ids"] == [3, 1, 5]
assert ragragproxyagent._results["ids"] == [[3, 1, 5]]

def test_custom_text_split_function(self):
def custom_text_split_function(text):
Expand Down