-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/azure ai inference client #5153
Feature/azure ai inference client #5153
Conversation
* Added: object-level usage data * Added: doc string * Added: check existing response_format value * Added: _validate_config and _create_client
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5153 +/- ##
==========================================
+ Coverage 70.24% 70.42% +0.18%
==========================================
Files 175 178 +3
Lines 11319 11581 +262
==========================================
+ Hits 7951 8156 +205
- Misses 3368 3425 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Great ! Especially for eg Codestral, and the new beautie in town Phi-4 too ! |
python/packages/autogen-ext/src/autogen_ext/models/azure/config/__init__.py
Show resolved
Hide resolved
895ee4a
to
5713ed8
Compare
python/packages/autogen-ext/src/autogen_ext/models/azure/_azure_ai_client.py
Outdated
Show resolved
Hide resolved
Looks great! Good to merge. The unit test could be using classes for mock, to allow for more reuse -- we can do it next time in the future. Same with unit test hitting the actual endpoint, we could have one that runs against a few different models. |
I agree that the unit tests could be more standardised for models. I tried not to change too much but i will have a look at this later. |
Why are these changes needed?
Related issue number
Checks