Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/azure ai inference client #5153

Merged

Conversation

lspinheiro
Copy link
Collaborator

Why are these changes needed?

Related issue number

Checks

@lspinheiro lspinheiro changed the base branch from feature/azure-ai-inference-client to main January 23, 2025 02:48
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 78.62595% with 56 lines in your changes missing coverage. Please review.

Project coverage is 70.42%. Comparing base (1982f1b) to head (61df629).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/src/autogen_ext/models/azure/_azure_ai_client.py 75.54% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
+ Coverage   70.24%   70.42%   +0.18%     
==========================================
  Files         175      178       +3     
  Lines       11319    11581     +262     
==========================================
+ Hits         7951     8156     +205     
- Misses       3368     3425      +57     
Flag Coverage Δ
unittests 70.42% <78.62%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zochory
Copy link

Zochory commented Jan 23, 2025

Great ! Especially for eg Codestral, and the new beautie in town Phi-4 too !

@lspinheiro lspinheiro force-pushed the feature/azure-ai-inference-client branch from 895ee4a to 5713ed8 Compare January 24, 2025 00:57
@lspinheiro lspinheiro requested a review from ekzhu January 24, 2025 06:23
@lspinheiro lspinheiro requested review from rohanthacker and jackgerrits and removed request for rohanthacker January 24, 2025 06:23
@ekzhu
Copy link
Collaborator

ekzhu commented Jan 24, 2025

Looks great! Good to merge. The unit test could be using classes for mock, to allow for more reuse -- we can do it next time in the future. Same with unit test hitting the actual endpoint, we could have one that runs against a few different models.

@lspinheiro
Copy link
Collaborator Author

Looks great! Good to merge. The unit test could be using classes for mock, to allow for more reuse -- we can do it next time in the future. Same with unit test hitting the actual endpoint, we could have one that runs against a few different models.

I agree that the unit tests could be more standardised for models. I tried not to change too much but i will have a look at this later.

@lspinheiro lspinheiro merged commit db2410c into microsoft:main Jan 24, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants