-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Add client close #5871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client close #5871
Conversation
…ches, while avoiding breaking changes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5871 +/- ##
==========================================
- Coverage 75.60% 75.57% -0.03%
==========================================
Files 189 189
Lines 12734 12754 +20
==========================================
+ Hits 9627 9639 +12
- Misses 3107 3115 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Created #5873 to track doc updates |
Fixes #4821 by adding a `close()` method to all clients. Additionally: * The m1 CLI is updated to close the client before exiting. * The playwrightcontroller is updated to suppress some other unrelated chatty warnings (e.g,, produced by markitdown when encountering conversions that require external utilities)
Fixes #4821 by adding a
close()method to all clients.Additionally: