Skip to content

Conversation

@peterychang
Copy link
Contributor

Why are these changes needed?

Fixes Screen Reader issue (58)

Related issue number

#5631

Checks

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.71%. Comparing base (ecdb74b) to head (cf63f08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5986   +/-   ##
=======================================
  Coverage   76.71%   76.71%           
=======================================
  Files         191      191           
  Lines       13191    13191           
=======================================
  Hits        10119    10119           
  Misses       3072     3072           
Flag Coverage Δ
unittests 76.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterychang
Copy link
Contributor Author

Actually, the version dropdown should be using aria-selected=true instead of aria-current

@ekzhu
Copy link
Contributor

ekzhu commented Mar 18, 2025

Actually, the version dropdown should be using aria-selected=true instead of aria-current

Should we include changing the dropdown class in this PR?

@peterychang
Copy link
Contributor Author

Actually, the version dropdown should be using aria-selected=true instead of aria-current

Should we include changing the dropdown class in this PR?

Yeah, I thought of this after I logged off for the day yesterday. I just got on long enough to note it down

@jackgerrits jackgerrits enabled auto-merge (squash) March 19, 2025 21:01
@jackgerrits jackgerrits disabled auto-merge March 19, 2025 21:01
@peterychang peterychang enabled auto-merge (squash) March 20, 2025 15:45
@peterychang peterychang merged commit 989d99d into microsoft:main Mar 20, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants