Support json schema for response format type in OpenAIChatCompletionClient#5988
Merged
Support json schema for response format type in OpenAIChatCompletionClient#5988
Conversation
jorge-wonolo
approved these changes
Mar 18, 2025
Contributor
jorge-wonolo
left a comment
There was a problem hiding this comment.
Works perfect to solve the issue filed under #5982
lspinheiro
approved these changes
Mar 18, 2025
Collaborator
lspinheiro
left a comment
There was a problem hiding this comment.
I think there are still some issues with the tests, but the main change looks good.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5988 +/- ##
==========================================
+ Coverage 76.68% 76.70% +0.02%
==========================================
Files 191 191
Lines 13152 13164 +12
==========================================
+ Hits 10085 10097 +12
Misses 3067 3067
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5982
This PR adds support for
json_schemaas aresponse_formattype inOpenAIChatCompletionClient. This is necessary because it allows the client to be serialized along with the schema. If user useresponse_format=SomeBaseModel, the client cannot be serialized.Usage: