Skip to content

Fix issue #5946: changed code for ACASessionsExecutor _ensure_access_token to be https:/ /dynamicsessions.io/.default #6001

Merged
ekzhu merged 2 commits intomicrosoft:mainfrom
EdwinInnovation:fix-issue-5946
Mar 20, 2025
Merged

Fix issue #5946: changed code for ACASessionsExecutor _ensure_access_token to be https:/ /dynamicsessions.io/.default #6001
ekzhu merged 2 commits intomicrosoft:mainfrom
EdwinInnovation:fix-issue-5946

Conversation

@EdwinInnovation
Copy link
Contributor

Why are these changes needed?

when I want to create a ACASessionsExecutor instance and execute some code, the default library imported does not work. It always returns: "ClientAuthenticationError: Authentication failed: AADSTS70011: The provided request must include a 'scope' input parameter. The provided value for the input parameter 'scope' is not valid. The scope https://dynamicsessions.io/ is not valid. Trace ID: d75efa58-8be7-44ef-8839-aacfdc850600 Correlation ID: a8e4d859-92da-4fbe-a8e0-05116323ab55 Timestamp: 2025-03-14 14:15:09Z"

After changing the scope in _ensure_access_token to be "https://dynamicsessions.io/.default" rather than ""https://dynamicsessions.io/" and it worked.

Related issue number

issue #5946

Checks

…e_access_token to be https:/

/dynamicsessions.io/.default rather than https://dynamicsessions.io/
@EdwinInnovation EdwinInnovation marked this pull request as draft March 19, 2025 07:21
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (9103359) to head (6ad0475).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._executors/azure/_azure_container_code_executor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6001   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files         191      191           
  Lines       13170    13170           
=======================================
  Hits        10106    10106           
  Misses       3064     3064           
Flag Coverage Δ
unittests 76.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EdwinInnovation
Copy link
Contributor Author

@ekzhu Could you please review this PR?

@ekzhu ekzhu marked this pull request as ready for review March 20, 2025 07:20
@ekzhu ekzhu enabled auto-merge (squash) March 20, 2025 07:21
@ekzhu ekzhu merged commit 3498c3c into microsoft:main Mar 20, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants