Skip to content

Added warnings for some GroupChat misconfigurations and selection errors #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonichi merged 4 commits into from
Nov 11, 2023
Merged

Added warnings for some GroupChat misconfigurations and selection errors #603

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5dcb53
Added warnings for some GroupChat misconfigurations and selection errors
afourney Nov 8, 2023
ab01777
Fixed formatting
afourney Nov 8, 2023
c3ead93
Merge branch 'main' into group_chat_selection_warnings
afourney Nov 9, 2023
bd0f6f1
Merge branch 'main' into group_chat_selection_warnings
afourney Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions autogen/agentchat/groupchat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def reset(self):
self.messages.clear()

def agent_by_name(self, name: str) -> Agent:
"""Find the next speaker based on the message."""
"""Returns the agent with a given name."""
return self.agents[self.agent_names.index(name)]

def next_agent(self, agent: Agent, agents: List[Agent]) -> Agent:
Expand Down Expand Up @@ -103,10 +103,20 @@ def select_speaker(self, last_speaker: Agent, selector: ConversableAgent):
try:
return self.agent_by_name(name)
except ValueError:
logger.warning(
f"GroupChat select_speaker failed to resolve the next speaker's name. Speaker selection will default to the next speaker in the list. This is because the speaker selection OAI call returned:\n{name}"
)
return self.next_agent(last_speaker, agents)

def _participant_roles(self):
return "\n".join([f"{agent.name}: {agent.system_message}" for agent in self.agents])
roles = []
for agent in self.agents:
if agent.system_message.strip() == "":
logger.warning(
f"The agent '{agent.name}' has an empty system_message, and may not work well with GroupChat."
)
roles.append(f"{agent.name}: {agent.system_message}")
return "\n".join(roles)


class GroupChatManager(ConversableAgent):
Expand Down