Skip to content

Conversation

@cheng-tan
Copy link
Contributor

@cheng-tan cheng-tan commented Mar 21, 2025

Why are these changes needed?

fix the accessibility issue that screen reader doesn't announce the theme when it changes

Related issue number

#5631 (13) (31) (59)

@cheng-tan cheng-tan requested a review from peterychang March 21, 2025 19:11
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.64%. Comparing base (26364e3) to head (0208270).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6061   +/-   ##
=======================================
  Coverage   76.64%   76.64%           
=======================================
  Files         191      191           
  Lines       13201    13201           
=======================================
  Hits        10118    10118           
  Misses       3083     3083           
Flag Coverage Δ
unittests 76.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cheng-tan cheng-tan changed the title [Accessibility] Fix: screen reader does not announce theme change [Accessibility] Fix: screen reader does not announce theme change and nested nav label Mar 21, 2025
@peterychang
Copy link
Contributor

lgtm

@peterychang peterychang merged commit 6f784ac into microsoft:main Mar 21, 2025
57 checks passed
@cheng-tan cheng-tan deleted the fix_accessibility branch March 22, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants