-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add session_id_param to ACADynamicSessionsCodeExecutor #6171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session_id_param to ACADynamicSessionsCodeExecutor #6171
Conversation
|
One outstanding question I have is what the behaviour should be if Ideas so far
Would be interested in thoughts :-) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6171 +/- ##
=======================================
Coverage 77.31% 77.32%
=======================================
Files 197 197
Lines 13797 13797
=======================================
+ Hits 10667 10668 +1
+ Misses 3130 3129 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
590ad8b to
79262e6
Compare
|
Looks like there is a pyright error. |
|
I think we can keep the current behavior with a note in the API doc. We can get feedback later.
|
733ac2b to
8784b7f
Compare
|
Added a note to make the behaviour when calling |
Why are these changes needed?
The initializer for ACADynamicSessionsCodeExecutor creates a new GUID to use as the session ID for dynamic sessions.
In some scenarios it is desirable to be able to re-create the agent group chat from saved state. In this case, the ACADynamicSessionsCodeExecutor needs to be associated with a previous instance (so that any execution state is still valid)
This PR adds a new argument to the initializer to allow a session ID to be passed in (defaulting to the current behaviour of creating a GUID if absent).
Related issue number
Closes #6119
Checks