Skip to content

Conversation

@zhanluxianshen
Copy link
Contributor

@zhanluxianshen zhanluxianshen commented Apr 3, 2025

Why are these changes needed?

1 redundancy code
2 first check error, then do logic.

Related issue number

Checks

Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
@zhanluxianshen zhanluxianshen force-pushed the clean-autogen_agentchat branch from bd048fd to a67f78b Compare April 4, 2025 00:33
@ekzhu ekzhu enabled auto-merge (squash) April 4, 2025 21:12
@ekzhu ekzhu merged commit 27e1656 into microsoft:main Apr 4, 2025
57 checks passed
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (3932126) to head (7b830de).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...chat/teams/_group_chat/_base_group_chat_manager.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6190   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         200      200           
  Lines       14237    14237           
=======================================
  Hits        11002    11002           
  Misses       3235     3235           
Flag Coverage Δ
unittests 77.27% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhanluxianshen zhanluxianshen deleted the clean-autogen_agentchat branch April 5, 2025 00:50
@zhanluxianshen
Copy link
Contributor Author

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants