Skip to content

Handled possible unclear IndexError in ConversableAgent.last_message method #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonichi merged 4 commits into from
Nov 11, 2023
Merged

Handled possible unclear IndexError in ConversableAgent.last_message method #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50db138
Handled possible IndexError in ConversableAgent.last_message method w…
jeezrick Nov 10, 2023
88564e1
Merge branch 'main' into feature/fix_last_message
sonichi Nov 11, 2023
c7ad6c0
Fix code formatting issues.
jeezrick Nov 11, 2023
6a34e4e
Merge branch 'feature/fix_last_message' of https://github.com/jeezric…
jeezrick Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions autogen/agentchat/conversable_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ def last_message(self, agent: Optional[Agent] = None) -> Dict:
for conversation in self._oai_messages.values():
return conversation[-1]
raise ValueError("More than one conversation is found. Please specify the sender to get the last message.")
if agent not in self._oai_messages.keys():
raise KeyError(
f"The agent '{agent.name}' is not present in any conversation. No history available for this agent."
)
return self._oai_messages[agent][-1]

@property
Expand Down
8 changes: 6 additions & 2 deletions test/agentchat/test_conversable_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,10 @@ def test_conversable_agent():
dummy_agent_1.update_system_message("new system message")
assert dummy_agent_1.system_message == "new system message"

dummy_agent_3 = ConversableAgent(name="dummy_agent_3", llm_config=False, human_input_mode="TERMINATE")
with pytest.raises(KeyError):
dummy_agent_1.last_message(dummy_agent_3)


def test_generate_reply():
def add_num(num_to_be_added):
Expand Down Expand Up @@ -242,7 +246,7 @@ async def test_a_generate_reply_raises_on_messages_and_sender_none(conversable_a


if __name__ == "__main__":
test_trigger()
# test_trigger()
# test_context()
# test_max_consecutive_auto_reply()
# test_conversable_agent(pytest.monkeypatch)
test_conversable_agent()