fix(openai): prioritize reasoning_content from model_extra for thinking content in tool call responses #7145
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For some LLM providers (e.g., Volcengine's doubao-seed models), when the model returns a function call response with thinking/reasoning content, the thinking content is stored in
choice.message.model_extra.get("reasoning_content")instead ofchoice.message.content.The current implementation only checked
choice.message.contentfor thinking content in tool call responses, which caused theThoughtEventto be missing when using these providers.Solution
In the
createmethod ofBaseOpenAIChatCompletionClient, when handling tool call responses, prioritize checkingreasoning_contentfrommodel_extrabefore falling back tomessage.content. This is consistent with the existing behavior for non-tool-call responses and thecreate_streammethod.Test Code
Results
Before this fix
After this fix