Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Should NameIsInformative rule filter out more frameworks? #874

Closed
DaveTryon opened this issue Feb 8, 2023 · 6 comments · Fixed by #878
Closed

[BUG] Should NameIsInformative rule filter out more frameworks? #874

DaveTryon opened this issue Feb 8, 2023 · 6 comments · Fixed by #878
Labels
status: resolved This issue has been merged into main.

Comments

@DaveTryon
Copy link
Contributor

DaveTryon commented Feb 8, 2023 •
edited
Loading

Describe the bug

The NameIsInformative rule exists for some very old framework bugs and is mostly noise for current frameworks. At the moment, the rule applies to all non-Win32 frameworks. Should we modify the Condition to apply it only to the frameworks that are known to have this problem in their old versions?
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Feb 8, 2023
@JGibson2019 JGibson2019 added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Feb 8, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Feb 8, 2023
@JGibson2019 JGibson2019 removed the status: new This issue is new and requires triage by DRI. label Feb 13, 2023
@DaveTryon
Copy link
Contributor Author

DaveTryon commented Feb 27, 2023 •
edited
Loading

We're trying to decide what changes, if any, are appropriate here.

@DaveTryon DaveTryon added help wanted Extra attention is needed status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. help wanted Extra attention is needed labels Feb 27, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

@codeofdusk codeofdusk mentioned this issue Mar 1, 2023
Merged
1 task
codeofdusk added a commit that referenced this issue Mar 3, 2023
@codeofdusk
Fix: Clarify "how to fix" guidance for NameIsInformative rule violati…
48116ec 
…ons (#878)

This commit adds additional guidance for when the `NameIsInformative` rule can be ignored safely.

Re #874.
@codeofdusk codeofdusk reopened this Mar 3, 2023
@codeofdusk codeofdusk mentioned this issue Mar 3, 2023
Merged
codeofdusk added a commit that referenced this issue Mar 8, 2023
@codeofdusk
fix: Exclude Group and Text controls from NameIsInformative due to hi…
902eb89 
…gh false-positive rate (#880)

This commit excludes the `Group` and `Text` UIA control types from the `NameIsInformative` rule in an attempt to reduce false positives.

Re #874.
@DaveTryon
Copy link
Contributor Author

We left the frameworks unchanged, but excluded Text and Group controls. We also updated the HowToFix text to make it clearer what the criterion is. Marking as resolved, will close it out once we release a new version of Axe.Windows

@DaveTryon DaveTryon added status: resolved This issue has been merged into main. and removed status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. labels Mar 8, 2023
@DaveTryon
Copy link
Contributor Author

We should close this only once we release an updated version of Axe.Windows

@DaveTryon DaveTryon assigned DaveTryon and unassigned asksep and DaveTryon Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: resolved This issue has been merged into main.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Clarify "how to fix" guidance for NameIsInformative rule violations codeofdusk/axe-windows
4 participants
@codeofdusk @asksep @JGibson2019 @DaveTryon