-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ESM modules #109
Comments
This package is broken out-of-the-box without ESM in Angular. Angular imports the |
The `node buildpackage.js` script now creates a `./bin/esm` folder, which contains an ESM version of this package. I've disabled minification for this folder, since I don't think it's very useful, and it just makes the package larger. We use https://nodejs.org/api/packages.html#conditional-exports to automatically map files to the ESM version when appropriate. The ESM version will work with most bundlers. However, since it's missing file-extensions (e.g. it uses `export * from "./Client";` instead of `export * from "./Client.js";`), some stricter ESM programs will not yet work with it. Fixes: microsoft#109
The `node buildpackage.js` script now creates a `./bin/esm` folder, which contains an ESM version of this package. I've disabled minification for this folder, since I don't think it's very useful, and it just makes the package larger. We use https://nodejs.org/api/packages.html#conditional-exports to automatically map files to the ESM version when appropriate. The ESM version will work with most bundlers. However, since it's missing file-extensions (e.g. it uses `export * from "./Client";` instead of `export * from "./Client.js";`), some stricter ESM programs will not yet work with it. Fixes: microsoft#109
The `node buildpackage.js` script now creates a `./bin/esm` folder, which contains an ESM version of this package. I've disabled minification for this folder, since I don't think it's very useful, and it just makes the package larger. We use https://nodejs.org/api/packages.html#conditional-exports to automatically map files to the ESM version when appropriate. The ESM version will work with most bundlers. However, since it's missing file-extensions (e.g. it uses `export * from "./Client";` instead of `export * from "./Client.js";`), some stricter ESM programs will not yet work with it. Fixes: microsoft#109
Is there any progress on this issue? Additionally, this module is not compatible with ViteJS. We would like to make it compatible with ESM, do you have any plans for that? |
If you are interested, I have a PR open that seems to work with ViteJS: #126. You can try it out by running It hasn't been updated for a while, though, it's still based of v4.229.0, which is a few months old. |
The related
azure-devops-extension-sdk
library kindly provides ESM modules that works with Vite.I suggest that
azure-devops-extension-api
does the same!The text was updated successfully, but these errors were encountered: